On Fri, Dec 12, 2008 at 3:49 AM, Benoit PAPILLAULT
<benoit.papillault@xxxxxxx> wrote:
> Nice catch! I wonder how it was working in my preliminary tests. Sorry
> for the duplicates with the same patch for ath9k. The padding/unpadding
> stuff is needed by the hardware, ie the hardware insert padding on RX
> and expect padding on TX, as mentioned in earlier ath5k and madwifi
> source code.
I should clarify: I meant Patrick already posted a fix for ath5k (and
possibly the ensuing discussion led to the ath9k patch). Anyway, let's
just get a patch in :)
The extra padding on TX side shouldn't hurt anything, OTOH, yeah it is
probably unnecessary to do it for ACK/CTS.
Also take a look at desc.c when setting up TX descriptor:
frame_len = pkt_len - (hdr_len & 3) + FCS_LEN;
What we have now will be 10 - 2 + 4 = 12 vs what should probably be 14.
--
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
