Aaradhana Sahu <quic_aarasahu@xxxxxxxxxxx> wrote:
> Smatch throws below error
>
> drivers/net/wireless/ath/ath12k/mac.c:8318 ath12k_mac_op_get_survey() error: we previously assumed 'sband' could be null
>
> Currently, we access sband inside the null check of the sband
> in ath12k_mac_op_get_survey().
>
> Fix this issue by removing the entire if block, because decrement
> idx is unnecessary since there are no more band to test.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Fixes: 70e3be54bbdd ("wifi: ath12k: fix survey dump collection in 6 GHz")
> Signed-off-by: Aaradhana Sahu <quic_aarasahu@xxxxxxxxxxx>
> Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>
2 patches applied to ath-next branch of ath.git, thanks.
59ca26c9a6e8 wifi: ath12k: fix NULL pointer access in ath12k_mac_op_get_survey()
19b77e7c656a wifi: ath12k: fix uninitialize symbol error on ath12k_peer_assoc_h_he()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240611031017.297927-2-quic_aarasahu@xxxxxxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
