On 6/10/2024 8:10 PM, Aaradhana Sahu wrote: > Smatch throws below error > > drivers/net/wireless/ath/ath12k/mac.c:8318 ath12k_mac_op_get_survey() error: we previously assumed 'sband' could be null > > Currently, we access sband inside the null check of the sband > in ath12k_mac_op_get_survey(). > > Fix this issue by removing the entire if block, because decrement > idx is unnecessary since there are no more band to test. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Fixes: 70e3be54bbdd ("wifi: ath12k: fix survey dump collection in 6 GHz") > Signed-off-by: Aaradhana Sahu <quic_aarasahu@xxxxxxxxxxx> Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>