On Tue, Dec 09, 2008 at 10:30:01PM -0600, Larry Finger wrote: > > key_v[0] = rxmic[0]; > > - key_v[1] = (txmic[0] >> 16) & 0xffff; > > + key_v[1] = cpu_to_le32(le32_to_cpu(txmic[0]) >> 16); > > Is it certain that txmic[0] will not sign extend with the >> 16 operation? Is > that why you dropped the mask with 0xffff? Yeah, I added the mask in the first place, but dropped it here because txmic is an __le32, and as far as I can tell all __le types are also unsigned, so it shouldn't sign extend. I'm not a language lawyer though so if anyone knows better, chime in (I just wrote a simple C program to convince myself). -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
