Bob Copeland wrote:
> Fix these bugs found by sparse:
>
> ath5k/pcu.c:1102:21: warning: restricted __le32 degrades to integer
> ath5k/pcu.c:1102:13: warning: incorrect type in assignment (different base types)
> ath5k/pcu.c:1102:13: expected restricted __le32 <noident>
> ath5k/pcu.c:1102:13: got unsigned int
> ath5k/pcu.c:1104:20: warning: restricted __le32 degrades to integer
> ath5k/pcu.c:1104:13: warning: incorrect type in assignment (different base types)
> ath5k/pcu.c:1104:13: expected restricted __le32 <noident>
> ath5k/pcu.c:1104:13: got unsigned int
>
> Changes-licensed-under: ISC
>
> Reported-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath5k/pcu.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/pcu.c b/drivers/net/wireless/ath5k/pcu.c
> index dabe422..0cac05c 100644
> --- a/drivers/net/wireless/ath5k/pcu.c
> +++ b/drivers/net/wireless/ath5k/pcu.c
> @@ -1099,9 +1099,9 @@ int ath5k_hw_set_key(struct ath5k_hw *ah, u16 entry,
>
> if (ah->ah_combined_mic) {
> key_v[0] = rxmic[0];
> - key_v[1] = (txmic[0] >> 16) & 0xffff;
> + key_v[1] = cpu_to_le32(le32_to_cpu(txmic[0]) >> 16);
Is it certain that txmic[0] will not sign extend with the >> 16 operation? Is
that why you dropped the mask with 0xffff?
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
