Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > > > Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > >> There is a confusing pattern in the kernel to use a variable named 'timeout' to > >> store the result of wait_for_completion_timeout() causing patterns like: > >> > >> timeout = wait_for_completion_timeout(...) > >> if (!timeout) return -ETIMEDOUT; > >> > >> with all kinds of permutations. Use 'time_left' as a variable to make the code > >> self explaining. > >> > >> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > > > Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > BTW Ping, you can also take it directly to your tree if you want. But if you > want me to take the patch, then please assign it to me on patchwork (ie. > change 'Delegate to' to 'kvalo'). My preference is to take it to your > tree, smaller risk of concflicts that way, but up to you. I will take it to my tree. Ping-Ke
