Krzysztof Kozlowski <krzk@xxxxxxxxxx> writes: > On 23/05/2024 09:08, Kalle Valo wrote: > >> Krzysztof Kozlowski <krzk@xxxxxxxxxx> writes: >> >>> On 21/05/2024 19:18, michael.nemanov@xxxxxx wrote: >>>> From: Michael Nemanov <Michael.Nemanov@xxxxxx> >>>> >>>> Various HW / FW / Driver controls unique for the CC33xx that >>>> can be set by OEMs. >>>> >>>> Signed-off-by: Michael Nemanov <michael.nemanov@xxxxxx> >>>> --- >>>> drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++ >>> >>> So you are adding one file by another? This does not help review. >>> >>> Add logical chunks, e.g. users of header after the header. Or all >>> headers together. Or some features incrementally, like basic working >>> driver and then feature foo and bar. >> >> For new wireless drivers my recommendation has been to submit for review >> one file per patch but the final driver to be commited would be just one >> patch: >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver > > Understood. Michael, it would be good to explain that in the cover letter so that people don't get confused about these multiple patches. Maybe even include the link? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
