On 21/05/2024 19:18, michael.nemanov@xxxxxx wrote: > From: Michael Nemanov <Michael.Nemanov@xxxxxx> > > Various HW / FW / Driver controls unique for the CC33xx that > can be set by OEMs. > > Signed-off-by: Michael Nemanov <michael.nemanov@xxxxxx> > --- > drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++ So you are adding one file by another? This does not help review. Add logical chunks, e.g. users of header after the header. Or all headers together. Or some features incrementally, like basic working driver and then feature foo and bar. Best regards, Krzysztof
