Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> wrote: > Currently, ath12k_wmi_pdev_dma_ring_cfg() fails due to an invalid pdev_id > parameter passed to the WMI_PDEV_DMA_RING_CFG_REQ_CMDID WMI command. This > invalid pdev_id is caused by a double conversion of the MAC ID. Since the > the caller of ath12k_wmi_pdev_dma_ring_cfg() already performs the MAC ID > conversion, it is unnecessary to do it again within the function. To fix > this, remove the software (SW) to hardware (HW) MAC ID conversion from > ath12k_wmi_pdev_dma_ring_cfg() to avoid this redundant conversion. > > Found in code review. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> > Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 2db7a82fd150 wifi: ath12k: avoid double SW2HW_MACID conversion -- https://patchwork.kernel.org/project/linux-wireless/patch/20240506173017.597715-1-quic_periyasa@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
