On Mon, 2008-12-08 at 15:20 +0100, Christian Lamparter wrote: > On Monday 08 December 2008 11:16:09 Johannes Berg wrote: > > On Tue, 2008-12-02 at 16:55 +0100, Christian Lamparter wrote: > > > > > Do you think "This callback is optional. Only use it, if your hardware/ > > > firmware really implements a station filter table" is enough (and correct spelled btw?) > > > Or do you volunteer for adding one or two DOC entries about APs, BC & MC Buffering, > > > TIM and station filters mechanism, caveats, and available callbacks or solutions? > > > > Incidentally, I was entirely wrong about the sta_notify callback being > > allowed to sleep, it's not, it's under a spinlock, and, more > > importantly, RCU read lock for station removal (and this cannot be > > changed). Must have been wishful thinking... > > > So? > can I move the notification enums STA_NOTIFY_SLEEP/STA_NOTIFY_AWAKE > to the sta_notify callback again, or is this wishful thinking as well? > After all, sta_notify wasn't intended to be used to tell the driver about > power state transitions but it does fit the bill... Don't bother, I just wanted to point out I had been wrong. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
