On Monday 01 December 2008 20:17:23 Luis R. Rodriguez wrote:
> On Sat, Nov 29, 2008 at 03:48:41PM -0800, Christian Lamparter wrote:
> > This patch is necessary in order to provide a proper Access point support for p54.
> > Unfortunately for us, there is no documented way to disable the interfering
> > power save buffering mechanism in firmware completely.
> >
> > Therefore we give in and notify the driver through our new sta_notify_ps callback,
> > so that we can update the filter state.
> >
> > Signed-off-by: Christian Lamparter <chunkeey@xxxxxx>
> > Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > ---
> > +/**
> > * enum ieee80211_tkip_key_type - get tkip key
> > *
> > * Used by drivers which need to get a tkip key for skb. Some drivers need a
> > @@ -1248,6 +1261,9 @@ enum ieee80211_ampdu_mlme_action {
> > * @sta_notify: Notifies low level driver about addition or removal
> > * of associated station or AP.
> > *
> > + * @sta_ps_notify: Notifies low level driver about the power state transition
> > + * of a associated station. Must be atomic.
> > + *
>
> Can we add documentation that this is only required when the AP cannot
> figure this out by itself? This can help people working on AP support to
> not think they need to implement this for all drivers.
Do you think "This callback is optional. Only use it, if your hardware/
firmware really implements a station filter table" is enough (and correct spelled btw?)
Or do you volunteer for adding one or two DOC entries about APs, BC & MC Buffering,
TIM and station filters mechanism, caveats, and available callbacks or solutions?
Regards,
Chr
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
