On 2024/3/14 18:41, Kalle Valo wrote:
Lingbo Kong <quic_lingbok@xxxxxxxxxxx> writes:
Ok, i will apply it in next version. Thanks for pointing out.
After rereading my comments maybe keep the title simple like:
wifi: ath12k: report station mode transmit rate
But it would be good to clarify in the commit message what modes
this is
supported. And what hardware families support this.
Hi kalle, Could you please offer your opinion on this commit message?
wifi: ath12k: report station mode transmit rate
Currently, the transmit rate of "iw dev xxx station dump" command
always show an invalid value.
To address this issue, ath12k parse the info of transmit complete
report from firmware and indicate the transmit rate to mac80211.
This patch only applies to the WCN7850's station mode.
After that, "iw dev xxx station dump" show the correct transmit rate.
Such as:
tx bitrate: 104.0 MBit/s MCS 13
tx bitrate: 144.4 MBit/s MCS 15 short GI tx bitrate: 626.9 MBit/s
80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 tx bitrate: 1921.5 MBit/s
160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0
Looks good, except for readability I would add an empty line after
"Such
as:".
I noticed that the signal patch depends on this patchset:
https://patchwork.kernel.org/project/linux-wireless/patch/20240219111417.1185-1-quic_lingbok@xxxxxxxxxxx/
In that you should submit both patchses in same patchset. But please
wait until I have reviewed the signal strength patch.
Hi Kalle,
Please ignore the patches submitted separately below.
[PATCH v4] wifi: ath12k: report tx bitrate for iw dev xxx station dump
[PATCH] wifi: ath12k: report signal for iw dev xxx station dump
[PATCH] wifi: ath12k: add display tx and rx bitrate for 11be
I will resubmit these patches in same patchset:)
Best regards,
Lingbo Kong
