Lingbo Kong <quic_lingbok@xxxxxxxxxxx> writes: > On 2024/2/28 19:08, Kalle Valo wrote: >> Lingbo Kong <quic_lingbok@xxxxxxxxxxx> writes: >> >>> On 2024/2/27 21:23, Kalle Valo wrote: >>>> Lingbo Kong <quic_lingbok@xxxxxxxxxxx> writes: >>>> >>>>> On 2024/2/26 23:37, Kalle Valo wrote: >>>>>> Please use full englist words like transmit instead of tx. Also the >>>>>> title could be simplified to: >>>>>> wifi: ath12k: report station mode transmit rate to user space >>>>>> Here I assumed this only works in station mode. Or does this also >>>>>> support AP and P2P mode? The commit message should explain that. >>>>>> >>>>> >>>>> Ok, i will apply it in next version. Thanks for pointing out. >>>> After rereading my comments maybe keep the title simple like: >>>> wifi: ath12k: report station mode transmit rate >>>> But it would be good to clarify in the commit message what modes >>>> this is >>>> supported. And what hardware families support this. >>> >>> Hi kalle, Could you please offer your opinion on this commit message? >>> >>> wifi: ath12k: report station mode transmit rate >>> >>> Currently, the transmit rate of "iw dev xxx station dump" command >>> always show an invalid value. >>> >>> To address this issue, ath12k parse the info of transmit complete >>> report from firmware and indicate the transmit rate to mac80211. >>> >>> This patch only applies to the WCN7850's station mode. >>> >>> After that, "iw dev xxx station dump" show the correct transmit rate. >>> Such as: >>> tx bitrate: 104.0 MBit/s MCS 13 >>> tx bitrate: 144.4 MBit/s MCS 15 short GI tx bitrate: 626.9 MBit/s >>> 80MHz HE-MCS 6 HE-NSS 2 HE-GI 0 HE-DCM 0 tx bitrate: 1921.5 MBit/s >>> 160MHz HE-MCS 9 HE-NSS 2 HE-GI 0 HE-DCM 0 >> Looks good, except for readability I would add an empty line after >> "Such >> as:". >> I noticed that the signal patch depends on this patchset: >> https://patchwork.kernel.org/project/linux-wireless/patch/20240219111417.1185-1-quic_lingbok@xxxxxxxxxxx/ >> In that you should submit both patchses in same patchset. But please >> wait until I have reviewed the signal strength patch. > > Hi, kalle, > > Would you mind if I kindly inquire whether you might have forgotten to > review "wifi: ath12k: report signal for iw dev xxx station dump" > patch? I don't rely on my memory and instead use patchwork for that: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork And the patch you are referring is in state 'New': https://patchwork.kernel.org/project/linux-wireless/patch/20240219111417.1185-1-quic_lingbok@xxxxxxxxxxx/ So it is in the queue, please just wait patiently. And as general comment to all Qualcomm engineers (not just Lingbo): if you want patches reviewed and applied faster then help Jeff and me! Review other patches, test our drivers and stack, investigate bug reports, make sure all firmware releases are uploaded etc. There is so much to do. Don't just throw patches over the wall and disappear. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
