Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Tue, 2008-12-02 at 22:03 +0200, Kalle Valo wrote: > >> - return ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS); >> + if (ps == local->powersave) >> + return ret; >> + >> +set: >> + local->powersave = ps; >> + >> + if (sdata->vif.type != NL80211_IFTYPE_STATION) >> + return ret; > > Shouldn't that test be earlier? There's little sense in supporting PS if > you have a non-STA interface. I'll move the test. > In fact, it might make sense to check that there's no other > interface (except monitor) open? I'll add this check as well. Thank you for the comments. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
