Search Linux Wireless

Re: [RFC PATCH v4 1/5] mac80211: enable IEEE80211_CONF_PS only when associated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2008-12-02 at 22:03 +0200, Kalle Valo wrote:

> -	return ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS);
> +	if (ps == local->powersave)
> +		return ret;
> +
> +set:
> +	local->powersave = ps;
> +
> +	if (sdata->vif.type != NL80211_IFTYPE_STATION)
> +		return ret;

Shouldn't that test be earlier? There's little sense in supporting PS if
you have a non-STA interface. In fact, it might make sense to check that
there's no other interface (except monitor) open?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux