On Wed, 27 Mar 2024 08:42:55 -0700 Jeff Johnson wrote: > On 3/27/2024 7:45 AM, Jakub Kicinski wrote: > > On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote: > >> -void init_dummy_netdev(struct net_device *dev) > >> +void init_dummy_netdev_core(struct net_device *dev) > > > > Can init_dummy_netdev_core() be a static function (and no export)? > > alloc_netdev_dummy() is probably going to be the only user. > > > > I'd also lean towards squashing the two commits into one. > > And once all of the conversions are complete, won't init_dummy_netdev() no > longer be used and can be removed? That's right, it should be removed. But it may take another release cycle until we can do that, depending on how quickly the patches propagate :(
