Search Linux Wireless

Re: [PATCH] ath10k: allocate dummy net_device dynamically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Breno Leitao <leitao@xxxxxxxxxx>
Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Wed, 27 Mar 2024 07:45:16 -0700
Cc: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Jeff Johnson <jjohnson@xxxxxxxxxx>, keescook@xxxxxxxxxxxx, "open list:NETWORKING DRIVERS (WIRELESS)" <linux-wireless@xxxxxxxxxxxxxxx>, "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" <ath10k@xxxxxxxxxxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <ZgQvTTnMoBn2oG1K@gmail.com>
References: <20240319104754.2535294-1-leitao@debian.org> <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> <20240321072821.59f56757@kernel.org> <5039256c-03eb-4cda-8d11-49e4561cf1ef@quicinc.com> <20240321151744.246ce2d0@kernel.org> <Zf2ceu2O47lLbKU3@gmail.com> <20240322082336.49f110cc@kernel.org> <ZgQvTTnMoBn2oG1K@gmail.com>

On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote:
>   -void init_dummy_netdev(struct net_device *dev)
>   +void init_dummy_netdev_core(struct net_device *dev)

Can init_dummy_netdev_core() be a static function (and no export)?
alloc_netdev_dummy() is probably going to be the only user.

I'd also lean towards squashing the two commits into one.

Follow-Ups:
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Jeff Johnson

References:
- [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Breno Leitao
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Jeff Johnson
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Jakub Kicinski
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Jeff Johnson
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Jakub Kicinski
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Breno Leitao
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Jakub Kicinski
- Re: [PATCH] ath10k: allocate dummy net_device dynamically
  - From: Breno Leitao

Prev by Date: Re: [PATCH v2 1/2] wifi: cfg80211/mac80211: Add support to rx retry stats
Next by Date: Re: [PATCH] ath10k: allocate dummy net_device dynamically
Previous by thread: Re: [PATCH] ath10k: allocate dummy net_device dynamically
Next by thread: Re: [PATCH] ath10k: allocate dummy net_device dynamically
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]