On 22/03/2024 07:22, Ping-Ke Shih wrote:
> On Wed, 2024-03-20 at 21:38 +0200, Bitterblue Smith wrote:
> [...]
>
>> +void rtl92d_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t)
>> +{
>> + struct rtl_priv *rtlpriv = rtl_priv(hw);
>> + struct rtl_hal *rtlhal = &rtlpriv->rtlhal;
>> + struct rtl_phy *rtlphy = &rtlpriv->phy;
>> + u32 timeout = 2000, timecount = 0;
>> +
>> + while (rtlpriv->mac80211.act_scanning && timecount < timeout) {
>> + udelay(50);
>> + timecount += 50;
>
> What is the purpose?
>
> Even if you really need it, just mdelay(2) or something like that? >
This comes from rtl8192de. The TX power tracking can re-do LC
calibration. Someone decided that shouldn't happen while
scanning. I don't know why.
>> + }
>> +
>> + rtlphy->lck_inprogress = true;
>> + RTPRINT(rtlpriv, FINIT, INIT_IQK,
>> + "LCK:Start!!! currentband %x delay %d ms\n",
>> + rtlhal->current_bandtype, timecount);
>> +
>> + _rtl92d_phy_lc_calibrate_sw(hw, is2t);
>> +
>> + rtlphy->lck_inprogress = false;
>> + RTPRINT(rtlpriv, FINIT, INIT_IQK, "LCK:Finish!!!\n");
>> +}
>> +
>
> [...]
>
>> +u8 rtl92d_phy_sw_chnl(struct ieee80211_hw *hw)
>> +{
>> +
>
> [...]
>
>> + while (rtlphy->lck_inprogress && timecount < timeout) {
>> + mdelay(50);
>> + timecount += 50;
>> + }
>
> Could LCK and switch channel happen simultaneously?
> Can you point out the case?
>
When a scan coincides with the TX power tracking deciding to
re-do LC calibration, I guess.
>
>> + if (rtlhal->macphymode == SINGLEMAC_SINGLEPHY &&
>> + rtlhal->bandset == BAND_ON_BOTH) {
>> + ret_value = rtl_get_bbreg(hw, RFPGA0_XAB_RFPARAMETER,
>> + MASKDWORD);
>> + if (rtlphy->current_channel > 14 && !(ret_value & BIT(0)))
>> + rtl92d_phy_switch_wirelessband(hw, BAND_ON_5G);
>> + else if (rtlphy->current_channel <= 14 && (ret_value & BIT(0)))
>> + rtl92d_phy_switch_wirelessband(hw, BAND_ON_2_4G);
>> + }
>> + switch (rtlhal->current_bandtype) {
>> + case BAND_ON_5G:
>> + /* Get first channel error when change between
>> + * 5G and 2.4G band.
>> + */
>> + if (WARN_ONCE(channel <= 14, "rtl8192de: 5G but channel<=14\n"))
>> + return 0;
>> + break;
>> + case BAND_ON_2_4G:
>> + /* Get first channel error when change between
>> + * 5G and 2.4G band.
>> + */
>> + if (WARN_ONCE(channel > 14, "rtl8192de: 2G but channel>14\n"))
>> + return 0;
>> + break;
>> + default:
>> + WARN_ONCE(true, "rtl8192de: Invalid WirelessMode(%#x)!!\n",
>> + rtlpriv->mac80211.mode);
>> + break;
>> + }
>> + rtlphy->sw_chnl_inprogress = true;
>> + if (channel == 0)
>> + channel = 1;
>
> Can this really happen?
>
I think it can't happen in rtl8192du. I will remove this check.
>
>
>> +
>> + /* notice fw know band status 0x81[1]/0x53[1] = 0: 5G, 1: 2G */
>> + if (rtlhal->current_bandtype == BAND_ON_2_4G) {
>> + value8 = rtl_read_byte(rtlpriv, mac_reg);
>> + value8 |= BIT(1);
>> + rtl_write_byte(rtlpriv, mac_reg, value8);
>> + } else {
>> + value8 = rtl_read_byte(rtlpriv, mac_reg);
>> + value8 &= (~BIT(1));
>> + rtl_write_byte(rtlpriv, mac_reg, value8);
>> + }
>> +
>> + if (rtlhal->macphymode == SINGLEMAC_SINGLEPHY) {
>> + value8 = rtl_read_byte(rtlpriv, REG_MAC0);
>> + rtl_write_byte(rtlpriv, REG_MAC0, value8 | MAC0_ON);
>> + } else {
>> + mutex_lock(&globalmutex_power);
>
> What do you need 'global' mutex? Usually, we want to support multiple instances
> run simultaneously. Does this mutext across instances?
> I feel not. Please move them into struct rtl_priv.
>
With the dual MAC version of RTL8192DU two instances of the
driver will access the same chip. This is why we have some
global mutexes. I think multiple devices can still work at the
same time, they will just slow each other down a little during
hardware init/deinit.
>> + if (rtlhal->interfaceindex == 0) {
>> + value8 = rtl_read_byte(rtlpriv, REG_MAC0);
>> + rtl_write_byte(rtlpriv, REG_MAC0, value8 | MAC0_ON);
>> + } else {
>> + value8 = rtl_read_byte(rtlpriv, REG_MAC1);
>> + rtl_write_byte(rtlpriv, REG_MAC1, value8 | MAC1_ON);
>> + }
>> + value8 = rtl_read_byte(rtlpriv, REG_POWER_OFF_IN_PROCESS);
>> + mutex_unlock(&globalmutex_power);
>
