On Tue, 2024-03-26 at 11:31 -0700, Pradeep Kumar Chitrapu wrote: > > On 3/26/2024 6:00 AM, Johannes Berg wrote: > > On Mon, 2024-03-25 at 13:10 -0700, Pradeep Kumar Chitrapu wrote: > > > Add flag for Full Bandwidth UL MU-MIMO for EHT. This is utilized > > > to pass EHT MU-MIMO configurations from user space to driver in > > > AP mode. > > > > This ^^ doesn't match this: > > > > > + * @eht_80mhz_full_bw_ul_mumimo: does this BSS support the reception (AP) or transmission > > > + * (non-AP STA) of an EHT TB PPDU on an RU that spans the entire PPDU > > > + * bandwidth > > > > > > > which doesn't match the implementation ... Wouldn't be a bad idea to > > actually do what it documents though, I guess? > > > Thanks Johannes for review. > can you please help clarify what you meant by "actually do what it > documents"? This will help me to amend next revision appropriately. > > I have tried to describe what this flag is trying to represent. Yes but ... you document AP and non-AP STA, but only implemented it for AP? johannes
