On 3/26/2024 6:00 AM, Johannes Berg wrote:
On Mon, 2024-03-25 at 13:10 -0700, Pradeep Kumar Chitrapu wrote:
Add flag for Full Bandwidth UL MU-MIMO for EHT. This is utilized
to pass EHT MU-MIMO configurations from user space to driver in
AP mode.
This ^^ doesn't match this:
+ * @eht_80mhz_full_bw_ul_mumimo: does this BSS support the reception (AP) or transmission
+ * (non-AP STA) of an EHT TB PPDU on an RU that spans the entire PPDU
+ * bandwidth
which doesn't match the implementation ... Wouldn't be a bad idea to
actually do what it documents though, I guess?
johannes
Thanks Johannes for review.
can you please help clarify what you meant by "actually do what it
documents"? This will help me to amend next revision appropriately.
I have tried to describe what this flag is trying to represent. This is
part of EHT MU-MIMO capabilities and driver may want to look at this
flag for MU-MIMO configurations.
Also this follows other parameters added to struct earlier.
example:
https://patchwork.kernel.org/project/linux-wireless/patch/1665006886-23874-2-git-send-email-quic_msinada@xxxxxxxxxxx/