Aloka Dixit <quic_alokad@xxxxxxxxxxx> writes: > On 3/18/2024 10:54 AM, Kalle Valo wrote: >> Kalle Valo <kvalo@xxxxxxxxxx> writes: >> >>> Aloka Dixit <quic_alokad@xxxxxxxxxxx> writes: >>> >>>> WMI_PEER_EXT_320MHZ (0x2) is defined as an extended flag, replace >>>> peer_flags by peer_flags_ext while sending peer data. >>>> >>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >>>> >>>> Fixes: 6734cf9b4cc7 ("wifi: ath12k: peer assoc for 320 MHz") >>>> Signed-off-by: Aloka Dixit <quic_alokad@xxxxxxxxxxx> >>> >>> What does this fix from user's point of view? Does it mean that 320 MHz >>> chanels were broken before and this commit fixes that? I can ammend the >>> commit message. >> And what about WCN7850? Does it work the same? > > 320 MHz association was broken. It was a re-basing error while sending > the original patch because the correct field was added during testing, > still used that way internally too. I have not tested WCN7850 on this > patch but yes will require the same field. Current code was setting > QOS bit instead of 320MHz. Thanks, does this look ok: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=c4ade6bdf3d1a2d9d05606a85431f154559d5a80 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches