On Tue, Mar 12, 2024 at 05:13:03PM -0700, Randy Dunlap wrote:
> Having an empty default: case in a switch statement causes a warning
> (when using Clang; I don't see the warning when using gcc),
> so add a "break;" to the default case to prevent the warning:
>
> drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]
It is a hard error with earlier versions of clang as well:
drivers/ssb/main.c:1148:10: error: label at end of compound statement: expected statement
default:
^
;
1 error generated.
> Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@xxxxxxxxx/
> Cc: Michael Büsch <m@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: llvm@xxxxxxxxxxxxxxx
Thanks for the quick fix!
Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> drivers/ssb/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/ssb/main.c b/drivers/ssb/main.c
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1144,6 +1144,7 @@ u32 ssb_dma_translation(struct ssb_devic
> return SSB_PCI_DMA;
> }
> default:
> + break;
> }
> return 0;
> }
>
