On Wed, 2024-02-28 at 11:36 +0000, Kalle Valo wrote:
> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > This really seems like a bug, endian conversions now happen
> > twice in this code.
> >
> > Note also that prior to the commit mentioned below, the code
> > was putting 16-bit values 0xBBAA as bytes "AA BB 00 00", and
> > the commit mentions making it work for 32-bit values and
> > makes no mention of fixing endian conversion; however, after
> > it, the bytes for 0xBBAA would now be "00 00 BB AA" on big
> > endian platforms.
> >
> > Remove one conversion to make sparse no longer warn.
> >
> > Not sure anyone can, has, or ever will use this on big endian
> > platforms though.
> >
> > Fixes: 0a60014b76f5 ("rsi: miscallaneous changes for 9116 and common")
> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> Fails to apply, I guess because I had a patch for this warning earlier.
>
You did pretty much the same thing anyway, no need to do anything else.
johannes
