Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> This really seems like a bug, endian conversions now happen
> twice in this code.
>
> Note also that prior to the commit mentioned below, the code
> was putting 16-bit values 0xBBAA as bytes "AA BB 00 00", and
> the commit mentions making it work for 32-bit values and
> makes no mention of fixing endian conversion; however, after
> it, the bytes for 0xBBAA would now be "00 00 BB AA" on big
> endian platforms.
>
> Remove one conversion to make sparse no longer warn.
>
> Not sure anyone can, has, or ever will use this on big endian
> platforms though.
>
> Fixes: 0a60014b76f5 ("rsi: miscallaneous changes for 9116 and common")
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
Fails to apply, I guess because I had a patch for this warning earlier.
Recorded preimage for 'drivers/net/wireless/rsi/rsi_91x_usb.c'
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: wifi: rsi: fix endian conversions
Using index info to reconstruct a base tree...
M drivers/net/wireless/rsi/rsi_91x_usb.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/net/wireless/rsi/rsi_91x_usb.c
CONFLICT (content): Merge conflict in drivers/net/wireless/rsi/rsi_91x_usb.c
Patch failed at 0001 wifi: rsi: fix endian conversions
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240223115214.682fb94159fa.I576bbf9fe7ca2948dbe3e00c0fa0f37594e85046@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
