Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > On February 12, 2024 5:03:14 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > >> Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: >> >>> On 2/12/2024 4:38 PM, Kalle Valo wrote: >>>> Alexey Berezhok <a@xxxxxxxxxx> wrote: >>>> >>>>> In 'brcmf_cfg80211_start_ap()', not assume that >>>>> NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer >>>>> an explicit check instead. Compile tested only. >>>>> >>>>> Found by Linux Verification Center (linuxtesting.org) with SVACE. >>>>> >>>>> Signed-off-by: Alexey Berezhok <a@xxxxxxxxxx> >>>> Patch applied to wireless-next.git, thanks. >>>> f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value >>>> to boolean >>> >>> Alexey, >>> >>> Can you do a follow-up patch addressing my comment? If not I will do >>> it myself. >> >> Sorry, was I not supposed to apply the patch? What did I miss? > > Nothing serious. settings->hidden_ssid value is used as-is to > configure firmware. I wanted Alexey to address that in a v2. My bad, I misunderstood your intentions. Luckily this time it wasn't serious. BTW to make super clear to me I would prefer that you (Arend) use Acked-by. It shows up in my script like the number '1' here: *[ 4] [next] wifi: carl9170: Remove redundant assignment t... 1 - - 2 5d Colin Ian Ki Under Review So if I don't see your Acked-by then I will not even look at the patch :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
