Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean

[Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx>]

On February 12, 2024 5:03:14 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote:

> Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:
>
> > On 2/12/2024 4:38 PM, Kalle Valo wrote:
> > > Alexey Berezhok <a@xxxxxxxxxx> wrote:
> > >
> > > > In 'brcmf_cfg80211_start_ap()', not assume that
> > > > NL80211_HIDDEN_SSID_NOT_IN_USE is zero but prefer
> > > > an explicit check instead. Compile tested only.
> > > >
> > > > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > > >
> > > > Signed-off-by: Alexey Berezhok <a@xxxxxxxxxx>
> > > Patch applied to wireless-next.git, thanks.
> > > f20073f50dfd wifi: brcmfmac: do not cast hidden SSID attribute value
> > > to boolean
> >
> > Alexey,
> >
> > Can you do a follow-up patch addressing my comment? If not I will do
> > it myself.
>
> Sorry, was I not supposed to apply the patch? What did I miss?

Nothing serious. settings->hidden_ssid value is used as-is to configure 
firmware. I wanted Alexey to address that in a v2.

Regards,
Arend

> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature