Search Linux Wireless

Re: [PATCH] wifi: brcmfmac: do not cast hidden SSID attribute value to boolean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On February 8, 2024 3:15:25 PM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:

On Thu, 2024-02-08 at 15:06 +0100, Arend van Spriel wrote:

settings->hidden_ssid has already been used above in following call:

err = brcmf_fil_iovar_int_set(ifp, "closednet",
  settings->hidden_ssid);

So we pass the value as is to firmware using the same assumption, ie.
NL80211_HIDDEN_SSID_NOT_IN_USE. Is this not ABI thus very unlikely to
change?

The ABI won't change, that'd break all the users of nl80211 that use
this :-)

Right. So basically the assumption that NL80211_HIDDEN_SSID_NOT_IN_USE is and will be zero is a safe one.


@Johannes:
Actually not quite understanding the reason for having this setting in
nl80211. hidden_ssid means SSID element length is zero, right?

Well, there at least _were_ APs doing the correct SSID length but
setting all octets to zero ... Not sure that's still a thing though.

I now looked at the definition and see indeed two distinct flavours of "hidden SSID". Interesting although I have never considered it a useful feature.

Regards,
Arend



Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux