On Sat, 2008-11-29 at 19:59 +1100, Shaddy Baddah wrote: > net/mac80211/tx.c:1304: if (memcmp(odev->dev_addr, hdr->addr4, > ETH_ALEN) != 0) > > I would have thought it would use compare_ether_addr() if we could > safely assume alignment. You're looking at the TX path, that's irrelevant :) > In any case, say that alignment was always the > intention... then can't we just use memcmp() as a hack (not being > derogatory. Just that it would turn into a hack in deference to using > compare_ether_addr()) consistent with hacks like the above? Even in the > interim until a program to iron out alignment is set in place? No, the IP stack assumes alignment. Besides, zd1211 actually enforces the alignment before passing the skb off to mac80211. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
