On Fri, 2008-11-28 at 23:45 +0100, Christian Lamparter wrote:
> /**
> * enum sta_notify_cmd - sta notify command
> *
> - * Used with the sta_notify() callback in &struct ieee80211_ops, this
> - * indicates addition and removal of a station to station table.
> + * Used with the sta_notify() callback in &struct ieee80211_ops.
> + * this command indicates addition and removal of a station to
> + * station table, or if a station made a power state transition.
> *
> * @STA_NOTIFY_ADD: a station was added to the station table
> * @STA_NOTIFY_REMOVE: a station being removed from the station table
> + * @STA_NOTIFY_SLEEP: a station is now sleeping
> + * @STA_NOTIFY_AWAKE: a sleeping station woke up
> */
> enum sta_notify_cmd {
> - STA_NOTIFY_ADD, STA_NOTIFY_REMOVE
> + STA_NOTIFY_ADD, STA_NOTIFY_REMOVE,
> + STA_NOTIFY_SLEEP, STA_NOTIFY_AWAKE,
> };
You know, I'm sorry, but I've come to realise that adding it to
sta_notify isn't a good idea after all. The one thing I forgot is that
this new callback has to be atomic because it's called from the rx path,
and sta_notify doesn't have to be.
Unless we want to defer RX packet processing to a workqueue rather than
a tasklet?
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
