Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Fri, 2008-11-28 at 21:49 +0200, Kalle Valo wrote: > >> + /* always wake queues to avoid having them stopped forever */ >> + netif_tx_wake_all_queues(local->mdev); > > I think we really need to think about keeping track of _who_ wanted the > queues stopped now... Makes sense. > We have a number of users of stopping queues now: > > * driver, obviously > * scanning code > * PS code > * ..? > > So when the driver wants a queue stopped, but the PS code wakes them up, > the driver will end up having to drop a packet, which isn't really good. > We really need to keep track, for each queue, who wants it > stopped/started and then only start the real queue if all the code > consents. Frankly I'm not that familiar with mac80211 queues, but it's a good time to learn now :) I'll look into this and will make a proposal. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
