Search Linux Wireless

Re: [RFC v3 2/4] mac80211: implement dynamic power save

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-11-28 at 21:49 +0200, Kalle Valo wrote:

> +	/* always wake queues to avoid having them stopped forever */
> +	netif_tx_wake_all_queues(local->mdev);

I think we really need to think about keeping track of _who_ wanted the
queues stopped now... We have a number of users of stopping queues now:

 * driver, obviously
 * scanning code
 * PS code
 * ..?

So when the driver wants a queue stopped, but the PS code wakes them up,
the driver will end up having to drop a packet, which isn't really good.
We really need to keep track, for each queue, who wants it
stopped/started and then only start the real queue if all the code
consents.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux