On Tue, 2024-01-23 at 13:42 -0800, Jakub Kicinski wrote: > > > We're also adding unit tests to iwlwifi (slowly), any idea if we should > > enable that here also? It _is_ now possible to build PCI stuff on kunit, > > but it requires some additional config options (virt-pci etc.), not sure > > that's desirable here? It doesn't need it at runtime for the tests, of > > course. > > but curious to hear about driver testing recommendations. Not sure I have any recommendations ... The test we posted is checking an invariant (the devinfo array is sorted in the right way); we used to have a check for this in the internal driver variant at init time, now it's a kunit test and we don't have to carry the delta to upstream here. I think Miri is also working on some additional tests for some driver- internal logic though. So not sure, I guess it'd be just like anything else you could use unit testing for, certain self-contained parts of the code that don't really otherwise need a device, etc.? johannes
