On 1/15/24 14:00, Johannes Berg wrote:
On Fri, 2024-01-12 at 11:58 -0800, Ben Greear wrote:
I tried backporting this patch into my 6.7 tree. An mtk7915 radio system blows up badly
in this case. Likely this is mt76 bug, but also...it used to work and the crash doesn't
make it very obvious that the above code is to blame.
Yeah, hence my comment about kernel developers hopefully being able to
figure it out :-)
mt7915e 0000:06:00.0: mt7915_register_device failed, ret: -22
mt7915e 0000:06:00.0: mt7915_pci_probe had error on try 3/3, ret: -22
Felix says this kind of retry logic doesn't exist upstream, maybe you
have some delta in your tree that's making it crash?
Also, from what he says and looking at the code, it should register with
HE 40 MHz capability set whenever has_he==true, so also here, do you
have any non-upstream changes that could affect it?
Yes, I do. Don't think I have anything that adjusts the 40Mhz, but possible.
Anyway, I know how to fix/work around it now, so if it works for Felix
then fine with me.
I still think you should have a pr_err or warn_on_once though, since if that clause
hits, at best case the radio suddenly became un-available.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
