Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes:
> On 13/01/2024 08:35, Kalle Valo wrote:
>
>> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes:
>>
>>> Currently it takes almost 6 seconds to upload the firmware for RTL8192CU
>>> (and 11 seconds for RTL8192DU). That's because the firmware is uploaded
>>> one byte at a time.
>>>
>>> Also, after plugging the device, the firmware gets uploaded three times
>>> before a connection to the AP is established.
>>>
>>> Maybe this is fine for most users, but when testing changes to the
>>> driver it's really annoying to wait so long.
>>>
>>> Speed up the firmware upload by writing chunks of 64 bytes at a time.
>>> This way it takes about 110 ms for RTL8192CU (and about 210 ms for
>>> RTL8192DU).
>>>
>>> PCI devices could upload it in chunks of 4 bytes, but I don't have any
>>> to test and commit 89d32c9071aa ("rtlwifi: Download firmware as bytes
>>> rather than as dwords") decided otherwise anyway.
>>>
>>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
>>
>> There's another version so I assume I can drop this one:
>>
>> https://patchwork.kernel.org/project/linux-wireless/patch/0d262acd-4f94-41c2-8d15-83486aeb976b@xxxxxxxxx/
>>
>
> Yes, you can drop this one. Sorry about that. I forgot to write
> "[PATCH]" in the subject. I thought you wouldn't even notice this
> one because of that.
I think patchwork assumes that any mail with a diff is a patch, like
this one:
https://patchwork.kernel.org/project/linux-wireless/patch/c7b331edd65b66521a6605177d654e55051568a3.camel@xxxxxxxxxxx/
So "[PATCH]" is more like a visual clue. BTW usually it's a good idea to
mark the next mail as v2 and explain in changelog what happened/changed,
that way everyone are on the same page. But no big deal, just trying to
make this smooth for everyone :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
