> -----Original Message----- > From: Ali Ghandour <gandour.ali@xxxxxxxxx> > Sent: Wednesday, January 3, 2024 2:09 AM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Subject: Re: Lenovo LOQ rtw_8852be > > Hello Ping-Ke, > > > After internal discussion, people suggest to implement DBI to access PCI config > > space as attached patch. Please help to revert workaround and apply this one, > > and give us kernel log to see if it works as expected. > > 1. I tried first to patch using below commands but it failed: > $ patch -p 2 -o pci.c pci.h < > ../0001-wifi-rtw89-pci-use-DBI-function-for-8852AE-8852BE-88.patch > What should I use instead? Normally, I use below command $ patch -p 1 -m -d path_to_rtw89 < xxx.patch > > 2. So I manually applied the changes and load the kernel: > [ 2428.566026] rtw89_8852be 0000:09:00.0: loaded firmware > rtw89/rtw8852b_fw-1.bin > [ 2428.568023] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5 > (da87cccd), cmd version 0, type 5 > [ 2428.568027] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5 > (da87cccd), cmd version 0, type 3 > [ 2428.847820] rtw89_8852be 0000:09:00.0: chip rfe_type is 1 > [ 2428.878840] rtw89_8852be 0000:09:00.0 wlp9s0: renamed from wlan0 > > rebooted and checked again and still working fine: > [ 3.227606] rtw89_8852be 0000:09:00.0: loaded firmware > rtw89/rtw8852b_fw-1.bin > [ 3.227870] rtw89_8852be 0000:09:00.0: enabling device (0000 -> 0003) > [ 3.229682] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5 > (da87cccd), cmd version 0, type 5 > [ 3.229684] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5 > (da87cccd), cmd version 0, type 3 > [ 3.542579] rtw89_8852be 0000:09:00.0: chip rfe_type is 1 > [ 3.574406] rtw89_8852be 0000:09:00.0 wlp9s0: renamed from wlan0 > Thanks for the help. I will submit this patch to upstream. Ping-Ke