Hi Rahul,
On Sun, Dec 31, 2023 at 4:04 PM Rahul Rameshbabu
<sergeantsagara@xxxxxxxxxxxxxx> wrote:
>
> bcm4331 seems to not function correctly with QoS support. This may be due
> to issues with currently available firmware or potentially a device
> specific issue.
>
> When queues that are not of the default "best effort" priority are
> selected, traffic appears to not transmit out of the hardware while no
> errors are returned. This behavior is present among all the other priority
> queues: video, voice, and background. While this can be worked around by
> setting a kernel parameter, the default behavior is problematic for most
> users and may be difficult to debug. This patch offers a working out-of-box
> experience for bcm4331 users.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@xxxxxxxxxxxxxx>
LGTM
Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
