On Fri, Dec 22, 2023 at 12:44 AM Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> wrote: > > This series adds the possibility to use two virtual interfaces on the > same channel. Supported combinations are STA+STA and STA+AP. The > conversion of the driver to support multiple interfaces is split into > individual patches to hopefully make it easier to understand what is > going on. > > Thanks, > Martin > > changes for v2: > - collect reviewed-by tags Please collect my reviewed-by again by v3. Thanks. > - coding style changess > - ignore CFO for STA+STA > - extend watchdog_callback to call refresh_rate_mask for both interfaces As comments, you can decide if extend it to all stations for AP mode. > - remove port_num check for BEACON change notifications > - add macids for STA mode > - add number of sec cam entries to rtl8xxxu_fileops > - add comment to switch_ports about using the function in the future A nit comment for this patch.