> -----Original Message----- > From: Martin Kaistra <martin.kaistra@xxxxxxxxxxxxx> > Sent: Friday, December 22, 2023 12:44 AM > To: linux-wireless@xxxxxxxxxxxxxxx > Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>; Kalle Valo <kvalo@xxxxxxxxxx>; Ping-Ke Shih > <pkshih@xxxxxxxxxxx>; Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>; Sebastian Andrzej Siewior > <bigeasy@xxxxxxxxxxxxx> > Subject: [PATCH v2 20/21] wifi: rtl8xxxu: make supporting AP mode only on port 0 transparent > [...] > + > + /* > + * priv->vifs[0] is NULL here, based on how this function is currently > + * called from rtl8xxxu_add_interface(). > + * When this function will be used in the future for a different > + * scenario, please check whether vifs[0] or vifs[1] can be NULL and if > + * necessary add code to set port_num = 1. > + */ Did you run scripts/checkpatch.pl to this patch? Initial line of comment block for networking code should not empty, so it should be below: + /* priv->vifs[0] is NULL here, based on how this function is currently + * called from rtl8xxxu_add_interface(). + * When this function will be used in the future for a different + * scenario, please check whether vifs[0] or vifs[1] can be NULL and if + * necessary add code to set port_num = 1. + */
