Johannes Berg wrote:
On Mon, 2008-11-24 at 06:44 +0100, Michael Renzmann wrote:
Hi.
Richard Farina wrote:
I recently saw this additional comment added to wireless-testing.git and
it has me a bit concerned. I use this feature for a specific patch set
that I maintain and it would break it pretty bad to remove this.
Just an idea: what prevents you to add a patch to that patchset that
reenables the amount of code you require from the CHAN_DEBUG stuff should
it be removed upstream?
Seconded, upstream should remove all the junk that it doesn't directly
need.
johannes
I actually don't have a problem with removing chan_debug, I was merely
requesting that the size hack it enables not be removed.
More specifically in base.h I believe the code I specifically require is:
#if CHAN_DEBUG
#define ATH_CHAN_MAX (26+26+26+200+200)
#else
#define ATH_CHAN_MAX (14+14+14+252+20)
#endif
When removing chan_debug just please leave the higher max. To be honest
I don't know for sure what this code means but since enabling it fixes
my patch it is clearly required. There is no reason to be removing this
as I am hoping to push a few patches upstream to properly support the
capabilities of the hardware.
Thanks,
Rick
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
