On Sat, 2008-11-22 at 20:20 +0200, Jouni Malinen wrote: > Well.. Maximum TX power is stored as dBm and it is used as dBm in > Country IE. Some of the current uses of EIRP seem to be converting the > values between dBm and mBm, so it does not look like the extra accuracy > would be needed there. Why was mBm used in the first place? It does not > seem to be used anywhere outside Linux regulatory code as a standard > unit which makes it quite a bit less obvious than dBm.. Yeah, true, I think we originally wanted it in the regulatory code and also push it throughout but then ended up converting it in the kernel. However, the userspace API is defined with the extra accuracy. > I kind of agree with consistency being a good reason for a change here, > but I just find the mBm a bit odd choice as a unit unless there is need > for greater accuracy than 1 dBm Broadcom hw at least supports 1/4 dBm steps, iirc. So it could at least make some sense. > (and in that case, the chan->max_power > value should likely be changed to use mBm, too). True, but that's in the kernel and much easier to change later than userspace APIs. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part