On Sat, Nov 22, 2008 at 06:54:24PM +0100, Johannes Berg wrote: > On Fri, 2008-11-21 at 19:01 +0200, Jouni Malinen wrote: > > > > + NLA_PUT_U8(msg, NL80211_FREQUENCY_ATTR_MAX_TX_POWER, > > + chan->max_power); > > + > > I think for consistency we should use the same format that the > regulatory stuff has for NL80211_ATTR_POWER_RULE_MAX_EIRP, i.e. a u32 > value with mBm (I think) Well.. Maximum TX power is stored as dBm and it is used as dBm in Country IE. Some of the current uses of EIRP seem to be converting the values between dBm and mBm, so it does not look like the extra accuracy would be needed there. Why was mBm used in the first place? It does not seem to be used anywhere outside Linux regulatory code as a standard unit which makes it quite a bit less obvious than dBm.. I kind of agree with consistency being a good reason for a change here, but I just find the mBm a bit odd choice as a unit unless there is need for greater accuracy than 1 dBm (and in that case, the chan->max_power value should likely be changed to use mBm, too). -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
