Search Linux Wireless

Re: [PATCH] wifi: cfg80211: Rename bssid to peer_addr in cfg80211_pmksa

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2023-11-20 at 11:54 +0530, Anuj Khera wrote:
> The cfg80211_pmksa structure uses bssid member to store
> the PMKSA for a BSS in Station mode. Change the name of
> structure member bssid to peer_addr so that same member
> can be used to store the PMKSA for a station in AP mode
> using station MAC address.
> 
> Signed-off-by: Anuj Khera <quic_akhera@xxxxxxxxxxx>
> ---

Please tag your patches with a version, and document the changes between
them.

>   *
> - * @bssid: The AP's BSSID (may be %NULL).
> + * @peer_addr: The AP's BSSID (may be %NULL) in case of Station mode. The STA's
> + *      mac address (may be %NULL) in case of AP mode.
> 

"MAC address", I guess?

And the "may be %NULL" really makes zero sense in AP mode, who are you
going to have the entry for?!

It barely even makes sense in client mode.

johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux