Hi Gregory and Anjaneyulu, On Sun, Oct 22, 2023 at 05:55:47PM +0300, gregory.greenman@xxxxxxxxx wrote: > From: Anjaneyulu <pagadala.yesu.anjaneyulu@xxxxxxxxx> > > The new firmware API uses a new command and notification, > the command configures in which statistics types driver is > interested and the notification is sent periodically. > An additional change in the API is that most of the statistics > data is accumulated and reported by the firmware per MLO link. > Implement new command and notification handlers and adjust to > per-link statistics. > > Signed-off-by: Anjaneyulu <pagadala.yesu.anjaneyulu@xxxxxxxxx> > Signed-off-by: Gregory Greenman <gregory.greenman@xxxxxxxxx> I'm seeing a warning at boot time due to this patch. See below. It's from 'WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg));'. Looks like there's an array that is supposed to be sorted that isn't sorted anymore. [ 5.342367] Intel(R) Wireless WiFi driver for Linux [ 5.342405] iwlwifi 0000:04:00.0: enabling device (0000 -> 0002) [ 5.342978] iwlwifi 0000:04:00.0: Detected crf-id 0xbadcafe, cnv-id 0x10 wfpm id 0x80000000 [ 5.342993] iwlwifi 0000:04:00.0: PCI dev 24fd/1010, rev=0x230, rfid=0xd55555d5 [ 5.343131] xhci_hcd 0000:01:00.0: xHCI Host Controller [ 5.343137] xhci_hcd 0000:01:00.0: new USB bus registered, assigned bus number 1 [ 5.346469] iwlwifi 0000:04:00.0: loaded firmware version 36.ca7b901d.0 8265-36.ucode op_mode iwlmvm [ 5.346502] ------------[ cut here ]------------ [ 5.346503] WARNING: CPU: 1 PID: 20 at drivers/net/wireless/intel/iwlwifi/mvm/../iwl-trans.h:1158 iwl_op_mode_mvm_start+0x995/0x9b0 [ 5.346511] CPU: 1 PID: 20 Comm: kworker/1:0 Not tainted 6.6.0-11999-gae7b1149d4fb #1 [ 5.346514] Hardware name: Gigabyte Technology Co., Ltd. X399 AORUS Gaming 7/X399 AORUS Gaming 7, BIOS F2 08/31/2017 [ 5.346516] Workqueue: events request_firmware_work_func [ 5.346520] RIP: 0010:iwl_op_mode_mvm_start+0x995/0x9b0 [ 5.346524] Code: 41 5e 41 5f 5d e9 2b 4c 59 00 cc 48 c7 c7 10 58 a2 ba 48 c7 c6 8a 0c a3 ba e8 87 f1 57 00 e9 b6 fb ff ff 0f 0b e9 b2 fe ff ff <0f> 0b e9 aa fc ff ff e8 6f 96 58 00 66 66 66 66 66 66 2e 0f 1f 84 [ 5.346526] RSP: 0018:ffffa87d402e7bf8 EFLAGS: 00010286 [ 5.346529] RAX: 00000000ffffffff RBX: ffffa87d402e7c00 RCX: ffffffffba721630 [ 5.346531] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffffffffba721cc0 [ 5.346532] RBP: ffff8ba7c72e0028 R08: 0000000000000090 R09: 0000000000000070 [ 5.346534] R10: 0000000000000070 R11: 00000000000000ff R12: ffff8ba7c7241f88 [ 5.346536] R13: ffff8ba7c6fff814 R14: ffff8ba7c7241f80 R15: 0000000000000000 [ 5.346537] FS: 0000000000000000(0000) GS:ffff8baf1e840000(0000) knlGS:0000000000000000 [ 5.346540] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 5.346541] CR2: 0000000000000000 CR3: 0000000056228000 CR4: 00000000003506f0 [ 5.346543] Call Trace: [ 5.346546] <TASK> [ 5.346548] ? __warn+0xa7/0x140 [ 5.346551] ? iwl_op_mode_mvm_start+0x995/0x9b0 [ 5.346554] ? report_bug+0xe8/0x180 [ 5.346557] ? handle_bug+0x3d/0x90 [ 5.346560] ? exc_invalid_op+0x1a/0x60 [ 5.346562] ? asm_exc_invalid_op+0x1a/0x20 [ 5.346566] ? iwl_op_mode_mvm_start+0x995/0x9b0 [ 5.346568] ? iwl_op_mode_mvm_start+0x63e/0x9b0 [ 5.346571] _iwl_op_mode_start+0x4e/0xa0 [ 5.346575] iwl_req_fw_callback+0x2501/0x2610 [ 5.346579] ? srso_return_thunk+0x5/0x5f [ 5.346582] ? __switch_to+0x80/0x480 [ 5.346586] request_firmware_work_func+0x62/0xa0 [ 5.346589] process_scheduled_works+0x263/0x3d0 [ 5.346593] worker_thread+0x222/0x300 [ 5.346595] ? __cfi_worker_thread+0x10/0x10 [ 5.346598] kthread+0xf4/0x110 [ 5.346602] ? __cfi_kthread+0x10/0x10 [ 5.346604] ret_from_fork+0x43/0x50 [ 5.346608] ? __cfi_kthread+0x10/0x10 [ 5.346610] ret_from_fork_asm+0x1b/0x30 [ 5.346614] </TASK> [ 5.346615] ---[ end trace 0000000000000000 ]--- [ 5.346617] iwlwifi 0000:04:00.0: Detected Intel(R) Dual Band Wireless AC 8265, REV=0x230
