> -----Original Message----- > From: Dmitry Antipov <dmantipov@xxxxxxxxx> > Sent: Monday, October 23, 2023 12:36 AM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Dmitry Antipov <dmantipov@xxxxxxxxx> > Subject: [PATCH] wifi: rtlwifi: cleanup struct rtl_hal > > Remove unused and set but otherwise unused 'bbrf_ready', 'external_pa', > 'pa_mode', 'rx_tag', 'rts_en', 'wow_enable', 'wow_enabled' and > 'hw_rof_enable' (which seems to be an erroneous duplication of the same > one of 'struct rtl_phy') fields of 'struct rtl_hal', adjust related > code. Why not removing 'hw_rof_enable' from 'struct rtl_phy'? Then, this patch can be _purely_ cleanup unused code. Ping-Ke
