> -----Original Message----- > From: Dmitry Antipov <dmantipov@xxxxxxxxx> > Sent: Sunday, October 22, 2023 9:31 PM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: On EDCCA control in rtlwifi > > I've noticed that 'rtl92ee_dm_dynamic_edcca()' and 'rtl8723be_dm_dynamic_edcca()' > are almost identical and both depends on 'pre_edcca_enable' of 'struct rtl_hal', > but only the first one can toggle it. Isn't it a bug somewhere? > Every chip has its hardware characteristic, so it may do that intentionally, and I can't find the reason why people did this. I suggest we don't touch EDCCA, because even I have a hardware, I still can't confirm test result is positive for the case the code intends to do. Ping-Ke