On Thu, Nov 20, 2008 at 8:56 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2008-11-19 at 15:32 -0800, Reinette Chatre wrote:
>
>
>> When the key is removed a second time the offset is set to 255 - this index
>> is not valid for the ucode_key_table and corrupts the eeprom pointer (which
>> is 255 bits from ucode_key_table).
>
>> + if (WARN(priv->stations[sta_id].sta.key.key_offset == WEP_INVALID_OFFSET,
>> + "Removing wrong key %d 0x%x\n", keyconf->keyidx, key_flags)) {
>> + spin_unlock_irqrestore(&priv->sta_lock, flags);
>> + return 0;
>> + }
>
> So, since _this_ patch has been tested to fix the problem, the WARN_ON
> must be triggering.
It fix the immediate problem of crashing the kernel but not the
problem why the key is removed twice.
I'm analyzing the log I've got from Carlos to figure this out you can
have a look as well.
It should be probably considered as a test patch. The purpose is not
to hide the bug buy fixing a symptom.
I suspect there is some problem in mac80211 is that this is happening
only on suspend/resumes not in regular flow
> What are you doing to address the actual bug that causes it to trigger?
If the flow of double removal of a key is okay from mac80211
perspective we just catch it internally which is always good otherwise
we need to fix also mac80211.
Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
