On 9/26/2023 7:09 AM, Johannes Berg wrote:
From: Johannes Berg <johannes.berg@xxxxxxxxx> There's no user for this, so remove the support. Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
if you are going to remove it, why not just revert e306784a8de0 ("cfg80211: AP mode driver offload for FILS association crypto") to make sure you get all of the artifacts? for example, I believe your patch will leave behind an unused struct cfg80211_fils_aad and unused FILS_AAD_ASSIGN() trace helper macro.
the caveat to reverting is that it should only be a partial revert; the UAPI definitions would need to be retained (and should be documented as obsolete).
however, let me check to make sure there is no plan to actually utilize this interface upstream. as i've indicated earlier, we are in the process of trying to transition to an "upstream first" mentality, but this is not going to happen overnight, but instead will take years. that said, i'd hate to rip out an interface now just to need to add it back in the future.
/jeff
