Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Tue, 2023-09-26 at 19:33 +0300, Kalle Valo wrote: >> >> - he_mcs_map = >> le16_to_cpu(ath11k_mac_get_tx_mcs_map(&sband->iftype_data->he_cap)); >> + he_cap = ieee80211_get_he_iftype_cap_vif(sband, arvif->vif); >> + he_mcs_map = le16_to_cpu(ath11k_mac_get_tx_mcs_map(he_cap)); > > Technically, ieee80211_get_he_iftype_cap_vif() could return NULL if you > didn't actually configure/enable HE for this iftype, the static checkers > might complain here. And this is even mentioned in the documentation which I failed to see: * Return: pointer to the struct ieee80211_sta_he_cap, or %NULL is none found Thanks! I'll fix this in v3. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
