On Mon, 2023-09-25 at 17:28 +0530, Aditya Kumar Singh wrote: > Currently, during channel switch, deflink (or link_id 0) is always > considered. However, with Multi-Link Operation (MLO), there is a > need to handle link specific data structures based on the actual > operational link_id during channel switch operation. > > Hence, add support for the same. Non-MLO based operations will use > link_id as 0 or deflink member as applicable. Much of this commit log really applies to mac80211 - perhaps make a simple cfg80211 patch first only? > + link_data = sdata_dereference(sdata->link[link_id], sdata); We should probably use wiphy_dereference() now? Perhaps we should just get rid of sdata_dereference() entirely, after all, it's the same now, just the arguments are switched for no good reason. > - conf = rcu_dereference_protected(sdata->vif.bss_conf.chanctx_conf, > + conf = rcu_dereference_protected(link_conf->chanctx_conf, > lockdep_is_held(&local->hw.wiphy->mtx)); Hm, I guess that was an artifact of the (mechanical) conversions - but really that should probably be wiphy_dereference() as well now? johannes