Hi Johannes, kernel test robot noticed the following build errors: [auto build test ERROR on linux-next/master] [also build test ERROR on linus/master v6.6-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/wifi-mac80211-ethtool-always-hold-wiphy-mutex/20230919-144127 base: linux-next/master patch link: https://lore.kernel.org/r/20230919084051.942b0bbde0ce.I7215d6cd3bcb4bb8631ddf872356408dd69477fe%40changeid patch subject: [PATCH] wifi: mac80211: ethtool: always hold wiphy mutex config: x86_64-randconfig-102-20230921 (https://download.01.org/0day-ci/archive/20230921/202309211239.sWxQtmqe-lkp@xxxxxxxxx/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309211239.sWxQtmqe-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309211239.sWxQtmqe-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): net/mac80211/ethtool.c: In function 'ieee80211_set_ringparam': >> net/mac80211/ethtool.c:27:13: error: 'sdata' undeclared (first use in this function); did you mean '_sdata'? wiphy_lock(sdata->local->hw.wiphy); ^~~~~ _sdata net/mac80211/ethtool.c:27:13: note: each undeclared identifier is reported only once for each function it appears in net/mac80211/ethtool.c: In function 'ieee80211_get_ringparam': net/mac80211/ethtool.c:43:13: error: 'sdata' undeclared (first use in this function); did you mean '_sdata'? wiphy_lock(sdata->local->hw.wiphy); ^~~~~ _sdata vim +27 net/mac80211/ethtool.c 15 16 static int ieee80211_set_ringparam(struct net_device *dev, 17 struct ethtool_ringparam *rp, 18 struct kernel_ethtool_ringparam *kernel_rp, 19 struct netlink_ext_ack *extack) 20 { 21 struct ieee80211_local *local = wiphy_priv(dev->ieee80211_ptr->wiphy); 22 int ret; 23 24 if (rp->rx_mini_pending != 0 || rp->rx_jumbo_pending != 0) 25 return -EINVAL; 26 > 27 wiphy_lock(sdata->local->hw.wiphy); 28 ret = drv_set_ringparam(local, rp->tx_pending, rp->rx_pending); 29 wiphy_unlock(sdata->local->hw.wiphy); 30 31 return ret; 32 } 33 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
